-
Notifications
You must be signed in to change notification settings - Fork 2
[feat] Migrate to st.components.v2.component API #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sfc-gh-bnisco
wants to merge
52
commits into
main
Choose a base branch
from
bnisco/ccv2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c064a0a to
444631b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
streamlit-bokehto utilize the newst.components.v2.component()API that was introduced in Streamlit 1.51.0There are a number of technical changes in this PR:
setup.pytopyproject.tomlBesides the technical changes, the remaining changes in this PR are to support moving to the new API. The main difference is that
v1.componentruns in an iframe, where asv2.componentdoes not.Bokeh.js has a specific loading order that is required in order for the scripts to work. The main Bokeh script must exist before the plugins can be loaded. Bokeh is accessed from a variable on
window. Due to these requirements, most of the actual changes in this PR is to support this loading order in a non-iframed environment.Demo app here.